Add computeIfAbsent variants for non-nullable types to stores#4760
Merged
marcphilipp merged 1 commit intomainfrom Jul 18, 2025
Merged
Add computeIfAbsent variants for non-nullable types to stores#4760marcphilipp merged 1 commit intomainfrom
computeIfAbsent variants for non-nullable types to stores#4760marcphilipp merged 1 commit intomainfrom
Conversation
Since both `ExtensionContext.Store` and its backing `NamespaceAwareStore` implementation allow storing `null` values, the `getOrComputeIfAbsent` methods potentially returned `null`, even if documented otherwise (in case of `getOrComputeIfAbsent(Class)` in `ExtensionContext.Store`). Now that the API uses JSpecify's nullability annotations, this became more apparent and also caused Jupiter `Extension` implementations to have to deal with values being potentially `null` despite their best intentions to only use `getOrComputeIfAbsent` to access a certain `key` with a function that never returned `null`. Therefore, this commit introduces null-safe variants called `computeIfAbsent` that treat `null` as absent in addition to the key not being present in the backing `Map`.
marcphilipp
changed the title
computeIfAbsent variants to stores for non-nullable typescomputeIfAbsent variants for non-nullable types to stores
Member
Author
|
Sam and I went through the code in today's team call without finding any issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since both
ExtensionContext.Storeand its backingNamespaceAwareStoreimplementation allow storingnullvalues, thegetOrComputeIfAbsentmethods potentially returnednull, even ifdocumented otherwise (in case of
getOrComputeIfAbsent(Class)inExtensionContext.Store). Now that the API uses JSpecify's nullabilityannotations, this became more apparent and also caused
Jupiter
Extensionimplementations to have to deal with values beingpotentially
nulldespite their best intentions to only usegetOrComputeIfAbsentto access a certainkeywith a function thatnever returned
null. Therefore, this commit introduces null-safevariants called
computeIfAbsentthat treatnullas absent inaddition to the key not being present in the backing
Map.I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations